Skip to content

perf: improve array/hash operation #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DayTF merged 3 commits into from
Jan 5, 2026
Merged

perf: improve array/hash operation #247

DayTF merged 3 commits into from
Jan 5, 2026

Conversation

@DayTF
Copy link
Contributor

@DayTF DayTF commented Dec 24, 2025

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 24, 2025

7 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 5): handle_request 4
qlty Structure Function with many parameters (count = 5): assign_many_to_one_records 2
qlty Structure Function with many returns (count = 5): lookup_relation 1

qltysh[bot]
qltysh bot reviewed Dec 24, 2025
View reviewed changes
.../lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb
end
end

def assign_many_to_one_records(caller, records, name, field_schema, projection)
Copy link

@qltysh qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): assign_many_to_one_records [qlty:function-parameters]

.../lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb
records.each { |record| record[name] = sub_records_by_key[record[field_schema.foreign_key]] }
end

def assign_to_one_or_many_records(caller, records, name, field_schema, projection)
Copy link

@qltysh qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): assign_to_one_or_many_records [qlty:function-parameters]

qltysh[bot]
qltysh bot reviewed Dec 24, 2025
View reviewed changes
...ges/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/parser/validation.rb
end
end

validations
Copy link

@qltysh qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 6): parse_column_validators [qlty:function-complexity]

@qltysh
Copy link

qltysh bot commented Dec 24, 2025

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (14)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
...st_admin_datasource_mongoid/utils/pipeline/lookup_generator.rb100.0%
Coverage rating: A Coverage rating: A
...gent/lib/forest_admin_agent/routes/capabilities/collections.rb100.0%
Coverage rating: A Coverage rating: A
...n_datasource_customizer/decorators/computed/utils/flattener.rb100.0%
Coverage rating: B Coverage rating: B
...est_admin_agent/lib/forest_admin_agent/services/permissions.rb100.0%
Coverage rating: A Coverage rating: A
...mongoid/lib/forest_admin_datasource_mongoid/parser/relation.rb100.0%
Coverage rating: C Coverage rating: C
...st_admin_datasource_mongoid/utils/pipeline/filter_generator.rb0.0%79
Coverage rating: C Coverage rating: C
...n_agent/lib/forest_admin_agent/serializer/forest_serializer.rb100.0%
Coverage rating: A Coverage rating: A
...ord/lib/forest_admin_datasource_active_record/parser/column.rb75.0%49
Coverage rating: C Coverage rating: C
...lib/forest_admin_datasource_customizer/composite_datasource.rb100.0%
Coverage rating: B Coverage rating: B
...ngoid/lib/forest_admin_datasource_mongoid/parser/validation.rb93.3%29
Coverage rating: A Coverage rating: A
...ustomizer/decorators/relation/relation_collection_decorator.rb94.1%246
Coverage rating: F Coverage rating: F
...lib/forest_admin_datasource_active_record/parser/validation.rb100.0%
Coverage rating: C Coverage rating: C
...e_mongoid/lib/forest_admin_datasource_mongoid/utils/helpers.rb100.0%
Coverage rating: A Coverage rating: A
...d/lib/forest_admin_datasource_mongoid/utils/add_null_values.rb100.0%
Total94.3%
🤖 Increase coverage with AI coding...

In the `perf/various-loop-improvements` branch, add test coverage for this new code:

- `packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/column.rb` -- Line 49
- `packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb` -- Line 246
- `packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/parser/validation.rb` -- Line 29
- `packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb` -- Line 79

🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@DayTF DayTF merged commit 9ca00fc into main Jan 5, 2026
37 checks passed
@DayTF DayTF deleted the perf/various-loop-improvements branch January 5, 2026 10:35
forest-bot added a commit that referenced this pull request Jan 5, 2026
@forest-bot
chore(release): 1.19.3 [skip ci]
aa8353f 
## [1.19.3](v1.19.2...v1.19.3) (2026-01-05)

### Performance Improvements

* improve array/hash operation ([#247](#247)) ([9ca00fc](9ca00fc))
@forest-bot
Copy link
Member

forest-bot commented Jan 5, 2026

🎉 This PR is included in version 1.19.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@matthv matthv matthv approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DayTF @forest-bot @matthv